chore: downgrade all info! logs to debug! - #3013
Open
mmustafasenoglu wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #3004, tantivy as a library should not emit info-level logs by default. All
info!calls are converted todebug!across 5 files:src/directory/managed_directory.rs— Garbage collect + file deletion logssrc/directory/mmap_directory/file_watcher.rs— Meta file modification logsrc/indexer/index_writer.rs— Buffer flush, rollback, commit logssrc/indexer/prepared_commit.rs— Commit logsrc/indexer/segment_updater.rs— Save metas, garbage collection, merge logsAs noted by @nwin in #3004, index creation/opening events could remain at info level in the future, but those are not currently logged so all existing info! calls are safe to downgrade.
Closes #3004